Redirect cursor hide/show to stderr #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
wagoodman
force-pushed
the
redirect-etui-cursor-to-stderr
branch
from
c3eaf9d to
c87f349
Compare
Benchmark Test ResultsBenchmark results from the latest changes vs base branch |
luhring
approved these changes
Jun 30, 2021
dakaneye
reviewed
Jun 30, 2021
There was a problem hiding this comment.
I'll be the first to admit my ANSI skills are lacking, but from what I can tell in the code changes, it looks like things were already logging to stderr, and had some questions re: the actual hide and show cursor methods (sorry if those questions are things I should know already)
The other question I have is if there's any testing required (but you've mentioned before that we haven't typically unit tested the ETUI stuff in the past)
| return nil | ||
| } | ||
|
|
||
| func hideCursor(output io.Writer) { | ||
| fmt.Fprint(output, "\x1b[?25l") |
There was a problem hiding this comment.
can we get a method comment to add some context here? I have some general questions that might be implicit in the method name, but want to make sure...
- what does the
\x1b[?25lcode correspond to? - why does printing it to the specified output stream hide the cursor?
These questions also apply to the showCursor method
There was a problem hiding this comment.
sorry @dakaneye , just as I merged your message popped up (I didn't refresh). I'll come back after the next couple of meetings and provide further context here 👍
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#448 pulled in an external lib to perform hiding/showing the cursor. However, this needs to be done relative to the right output stream (in our case, stderr), otherwise
syft | lesswill continue to show the cursor.This PR restores this functionality.